Fix typo in language name #829
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The country is Slovenia, the Language is Slovenian - this commit fixes the typo. Question: Slovenian isn't the main language in any other country, so only `sl.js` was expected. Spanish has `es.js` (Spanish, no location given) and not `es-ES.js` (Spanish-Spain), while other variants would also exist (Spanish Mexican, Costa rican, Colombian, Panama,... about 20 in total). Can we rename `sl-SI` to `sl`? The ICU Locale `sl` is valid: https://www.localeplanet.com/java/sl/index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The country is Slovenia, the Language is Slovenian - this commit fixes the typo.
Question: Slovenian isn't the main language in any other country, so only
sl.jswas expected. Spanish hases.js(Spanish, no location given) and notes-ES.js(Spanish-Spain), while other variants would also exist (Spanish Mexican, Costa rican, Colombian, Panama,... about 20 in total).Can we rename
sl-SItosl? The ICU Localeslis valid: https://www.localeplanet.com/java/sl/index.html