Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added attachments #25

Merged
merged 2 commits into from Jan 28, 2014
Merged

Added attachments #25

merged 2 commits into from Jan 28, 2014

Conversation

robertf224
Copy link
Contributor

Added two lines to Message class to support attachments and an Attachment class to represent attachment objects. Attachments to an email are stored in an array (message.attachments). Attachment objects have name and size (kilobytes) properties, and their associated files can be saved to disk using the save() function, which optionally takes a path to save the file to. I updated the README to show capabilities, though you very well might want to represent the information differently.

@lesthack
Copy link

iv'e a problem with this search:
g.inbox().mail(unread=True, attachment=True)

@ekianjo
Copy link

ekianjo commented Jan 23, 2014

So what's the status on this functionality ? what works and what does not work ?

@robertf224
Copy link
Contributor Author

All I added was access to the attachments (if there are any) of fetched emails wrapped as objects of a convenience Attachment class. You can see how to access them in the Readme of my fork of the project. I'll look into allowing a search for emails with attachments when I have time next week!

@odino
Copy link

odino commented Jan 24, 2014

Any plan to merge this? :)

@charlierguo
Copy link
Owner

Yep! I've just gotten back from traveling for the past few months, so I
haven't had a lot of time for development, but I'll be taking a look at all
the issues and pull requests.

On Friday, January 24, 2014, Alessandro Nadalin notifications@github.com
wrote:

Any plan to merge this? :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/25#issuecomment-33220762
.

charlierguo added a commit that referenced this pull request Jan 28, 2014
@charlierguo charlierguo merged commit 667c149 into charlierguo:master Jan 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants