Avoid false-positive in chained type calls (#2663)

astral-sh · Feb 8, 2023 · 7482a4a · 7482a4a
1 parent 9f9f25f
commit 7482a4a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/crates/ruff/resources/test/fixtures/pyupgrade/UP003.py b/crates/ruff/resources/test/fixtures/pyupgrade/UP003.py
@@ -10,3 +10,4 @@
 # OK
 type = lambda *args, **kwargs: None
 type("")
+type(arg)(" ")
diff --git a/crates/ruff/src/checkers/ast.rs b/crates/ruff/src/checkers/ast.rs
@@ -2280,7 +2280,7 @@ where
 
                 // pyupgrade
                 if self.settings.rules.enabled(&Rule::TypeOfPrimitive) {
-                    pyupgrade::rules::type_of_primitive(self, expr, func, args);
+                    pyupgrade::rules::type_of_primitive(self, expr, args);
                 }
                 if self.settings.rules.enabled(&Rule::DeprecatedUnittestAlias) {
                     pyupgrade::rules::deprecated_unittest_alias(self, func);

diff --git a/crates/ruff/src/rules/pyupgrade/rules/type_of_primitive.rs b/crates/ruff/src/rules/pyupgrade/rules/type_of_primitive.rs
@@ -27,12 +27,12 @@ impl AlwaysAutofixableViolation for TypeOfPrimitive {
 }
 
 /// UP003
-pub fn type_of_primitive(checker: &mut Checker, expr: &Expr, func: &Expr, args: &[Expr]) {
+pub fn type_of_primitive(checker: &mut Checker, expr: &Expr, args: &[Expr]) {
     if args.len() != 1 {
         return;
     }
     if !checker
-        .resolve_call_path(func)
+        .resolve_call_path(expr)
         .map_or(false, |call_path| call_path.as_slice() == ["", "type"])
     {
         return;