Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict SIM105 to try blocks with a body of one simple statement #1948

Merged
merged 1 commit into from Jan 18, 2023

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Jan 18, 2023

If a try block has multiple statements, a compound statement, or control flow, rewriting it with contextlib.suppress would obfuscate the fact that the exception still short-circuits further statements in the block.

Fixes #1947.

If a `try` block has multiple statements, a compound statement, or
control flow, rewriting it with `contextlib.suppress` would obfuscate
the fact that the exception still short-circuits further statements in
the block.

Fixes astral-sh#1947.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@charliermarsh charliermarsh merged commit ea4d54a into astral-sh:main Jan 18, 2023
@andersk andersk deleted the restrict-sim105 branch January 18, 2023 05:23
bruxisma pushed a commit to ixm-one/pytest-cmake-presets that referenced this pull request Jan 18, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.224` ->
`^0.0.225` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.225/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.225/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.225/compatibility-slim/0.0.224)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.225/confidence-slim/0.0.224)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.225`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.225)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.224...v0.0.225)

#### What's Changed

- Define origin names & URLs within doc comments by
[@&#8203;not-my-profile](https://togithub.com/not-my-profile) in
[astral-sh/ruff#1929
- Refactor settings by
[@&#8203;not-my-profile](https://togithub.com/not-my-profile) in
[astral-sh/ruff#1930
- Allow duplicate enum values for enum.auto() by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1933
- Move `@functools.cache` rewrites to their own rule by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1938
- cli: Catch panics to tell the user to report them by
[@&#8203;not-my-profile](https://togithub.com/not-my-profile) in
[astral-sh/ruff#1928
- Avoid autofixing comma rules when --fix is not set by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1940
- Avoid broken autofix for `SIM103` with `elif` by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1944
- Implement `flake8-no-pep420` by
[@&#8203;edgarrmondragon](https://togithub.com/edgarrmondragon) in
[astral-sh/ruff#1942
- Exempt `contextlib.ExitStack()` for SIM115 rules by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1946
- Restrict SIM105 to try blocks with a body of one simple statement by
[@&#8203;andersk](https://togithub.com/andersk) in
[astral-sh/ruff#1948

**Full Changelog**:
astral-sh/ruff@v0.0.224...v0.0.225

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDUuMyIsInVwZGF0ZWRJblZlciI6IjM0LjEwNS4zIn0=-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@not-my-profile
Copy link
Contributor

Could you give an example of how contextlib.suppress would obfuscate this?

@andersk
Copy link
Contributor Author

andersk commented Feb 14, 2023

I gave an example in #1947.

for i in range(1, 100):
    try:
        realm.string_id = prefix + str(i)
        realm.save(update_fields=["string_id"])
        break
    except IntegrityError:
        pass
else:
    raise RuntimeError(f"Unable to find a good string_id for realm {realm}")

@not-my-profile
Copy link
Contributor

Ah, my bad I didn't see the issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should SIM105 UseContextlibSuppress exempt try blocks with unreachable end?
3 participants