Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect self as positional-only argument in annotation rules #2927

Merged
merged 1 commit into from Feb 15, 2023

Conversation

charliermarsh
Copy link
Member

Closes #2925.

@charliermarsh charliermarsh added the bug Something isn't working label Feb 15, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) February 15, 2023 15:23
@charliermarsh charliermarsh merged commit cb971d3 into main Feb 15, 2023
@charliermarsh charliermarsh deleted the charlie/ord branch February 15, 2023 15:25
renovate bot added a commit to ixm-one/pytest-cmake-presets that referenced this pull request Feb 16, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.246` ->
`^0.0.247` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.247/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.247/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.247/compatibility-slim/0.0.246)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.247/confidence-slim/0.0.246)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.247`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.247)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.246...v0.0.247)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Rules

- \[`NPY001`] deprecated type aliases by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2810
- \[`RUF006`] Implement `asyncio-dangling-task` to track
`asyncio.create_task` calls by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2935

##### CLI

- Implement shell autocompletion for rule codes by
[@&#8203;not-my-profile](https://togithub.com/not-my-profile) in
[astral-sh/ruff#2906

##### Bug Fixes

- Handle multiple receiver decorators in receiver-decorator by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2858
- Avoid false-positives with multi-byte characters in B005 by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2862
- Avoid false-positives for runtime-types in type checking blocks by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2863
- Avoid noqa removal upon unhandled syntax errors by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2864
- Ignore non-imperative-mood in Google docstring convention by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2900
- \[`flake8-tidy-imports`] autofix relative imports by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2891
- Respect self as positional-only argument in annotation rules by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2927
- Apply nullable-model-string-field to all classes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2928
- Deduplicate files provided on the command-line by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2931
- Re-show --target-version on CLI interface by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2859
- Remove autofix for prefer-type-error by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2880
- Avoid unnecessary-else violations in `elif` branches by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2881
- Extend B904 to else branches by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2886
- Allow private accesses on current class by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2929

#### New Contributors

- [@&#8203;Jeremiah-England](https://togithub.com/Jeremiah-England) made
their first contribution in
[astral-sh/ruff#2884
- [@&#8203;Chris-May](https://togithub.com/Chris-May) made their first
contribution in
[astral-sh/ruff#2896
- [@&#8203;simon04](https://togithub.com/simon04) made their first
contribution in
[astral-sh/ruff#2904

**Full Changelog**:
astral-sh/ruff@v0.0.246...v0.0.247

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMzguMyIsInVwZGF0ZWRJblZlciI6IjM0LjEzOC4zIn0=-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to allenporter/flux-local that referenced this pull request Feb 18, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.246` ->
`==0.0.247` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.247/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.247/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.247/compatibility-slim/0.0.246)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.247/confidence-slim/0.0.246)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.247`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.247)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.246...v0.0.247)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Rules

- \[`NPY001`] deprecated type aliases by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2810
- \[`RUF006`] Implement `asyncio-dangling-task` to track
`asyncio.create_task` calls by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2935

##### CLI

- Implement shell autocompletion for rule codes by
[@&#8203;not-my-profile](https://togithub.com/not-my-profile) in
[astral-sh/ruff#2906

##### Bug Fixes

- Handle multiple receiver decorators in receiver-decorator by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2858
- Avoid false-positives with multi-byte characters in B005 by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2862
- Avoid false-positives for runtime-types in type checking blocks by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2863
- Avoid noqa removal upon unhandled syntax errors by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2864
- Ignore non-imperative-mood in Google docstring convention by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2900
- \[`flake8-tidy-imports`] autofix relative imports by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2891
- Respect self as positional-only argument in annotation rules by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2927
- Apply nullable-model-string-field to all classes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2928
- Deduplicate files provided on the command-line by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2931
- Re-show --target-version on CLI interface by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2859
- Remove autofix for prefer-type-error by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2880
- Avoid unnecessary-else violations in `elif` branches by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2881
- Extend B904 to else branches by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2886
- Allow private accesses on current class by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2929

#### New Contributors

- [@&#8203;Jeremiah-England](https://togithub.com/Jeremiah-England) made
their first contribution in
[astral-sh/ruff#2884
- [@&#8203;Chris-May](https://togithub.com/Chris-May) made their first
contribution in
[astral-sh/ruff#2896
- [@&#8203;simon04](https://togithub.com/simon04) made their first
contribution in
[astral-sh/ruff#2904

**Full Changelog**:
astral-sh/ruff@v0.0.246...v0.0.247

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDMuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE0My4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruff mistakes with Protocol and positional-only arguments.
1 participant