Fix UP036 auto-fix error #4679

JonathanPlasse · 2023-05-27T13:04:11Z

Close [Autofix error] UP036 autofix fails on complex nested block #4522

Summary

The BlockMetadata was incorrect. It was picking up else and elif tokens inside the if body.
Now, it will skip all tokens inside the if body.

Test Plan

A fixture with the failing auto-fix has been added.

JonathanPlasse · 2023-05-27T13:06:52Z

crates/ruff/src/rules/pyupgrade/rules/outdated_version_block.rs

+    let located_start = located.start();
+    let text = locator.slice(TextRange::new(located_start, located.end()));
+    let body_end = body.last().map(Ranged::end).unwrap();


Using located.start() does not seem to change the behavior.

github-actions · 2023-05-27T13:16:44Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     14.5±0.32ms     2.8 MB/sec    1.00     14.5±0.38ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.4±0.04ms     4.9 MB/sec    1.00      3.4±0.03ms     4.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    423.8±1.29µs     7.0 MB/sec    1.00    425.0±2.26µs     6.9 MB/sec
linter/all-rules/pydantic/types.py         1.02      6.0±0.09ms     4.3 MB/sec    1.00      5.8±0.05ms     4.4 MB/sec
linter/default-rules/large/dataset.py      1.00      6.8±0.07ms     6.0 MB/sec    1.01      6.9±0.06ms     5.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1497.8±4.09µs    11.1 MB/sec    1.00   1499.0±1.45µs    11.1 MB/sec
linter/default-rules/numpy/globals.py      1.00    170.5±0.45µs    17.3 MB/sec    1.00    170.9±0.31µs    17.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.1±0.01ms     8.3 MB/sec    1.00      3.1±0.01ms     8.2 MB/sec
parser/large/dataset.py                    1.00      5.2±0.01ms     7.9 MB/sec    1.00      5.2±0.01ms     7.9 MB/sec
parser/numpy/ctypeslib.py                  1.00   1019.4±1.28µs    16.3 MB/sec    1.00   1022.1±1.19µs    16.3 MB/sec
parser/numpy/globals.py                    1.00    105.4±0.18µs    28.0 MB/sec    1.00    105.9±0.37µs    27.9 MB/sec
parser/pydantic/types.py                   1.00      2.2±0.00ms    11.5 MB/sec    1.00      2.2±0.01ms    11.4 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     16.8±0.43ms     2.4 MB/sec    1.00     16.7±0.41ms     2.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.3±0.14ms     3.9 MB/sec    1.00      4.2±0.06ms     3.9 MB/sec
linter/all-rules/numpy/globals.py          1.01   507.0±17.74µs     5.8 MB/sec    1.00    500.0±6.72µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.1±0.17ms     3.6 MB/sec    1.00      7.1±0.11ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.08      8.8±0.42ms     4.6 MB/sec    1.00      8.2±0.07ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.02  1804.9±43.81µs     9.2 MB/sec    1.00  1761.1±18.05µs     9.5 MB/sec
linter/default-rules/numpy/globals.py      1.00    208.0±6.50µs    14.2 MB/sec    1.00   207.9±11.09µs    14.2 MB/sec
linter/default-rules/pydantic/types.py     1.02      3.8±0.08ms     6.7 MB/sec    1.00      3.7±0.07ms     6.8 MB/sec
parser/large/dataset.py                    1.14      7.5±0.12ms     5.4 MB/sec    1.00      6.6±0.12ms     6.2 MB/sec
parser/numpy/ctypeslib.py                  1.12  1388.1±25.30µs    12.0 MB/sec    1.00  1241.8±22.32µs    13.4 MB/sec
parser/numpy/globals.py                    1.09    137.1±3.08µs    21.5 MB/sec    1.00    125.4±2.57µs    23.5 MB/sec
parser/pydantic/types.py                   1.11      3.1±0.07ms     8.1 MB/sec    1.00      2.8±0.07ms     9.0 MB/sec

charliermarsh · 2023-05-27T19:42:19Z

crates/ruff/src/rules/pyupgrade/rules/outdated_version_block.rs

+        } else if range.start() < body_end {
+            // Continue until the end of the `if` body, thus ensuring that we don't
+            // accidentally pick up an `else` or `elif` in the nested block.
+            continue;


What if there's an else in the elif block body? Would we not accidentally flag that as the final else?

We need elif or else or neither, We do not need both. So, I simplified the logic.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `^0.0.270` -> `^0.0.271` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.271`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).  Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `0.0.270` -> `0.0.272` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272)  #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4917 ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@density](https://togithub.com/density) in [astral-sh/ruff#4884 ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4942 - Skip class scopes when resolving nonlocal references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4943 - Apply `dict.get` fix before ternary rewrite by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4944 - Handle implicit string concatenations in conversion-flag rewrites by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4947 - Make `C413` fix as suggested for `reversed` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4891 - ignore if using infinite iterators in `B905` by [@kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#4914 **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/jankatins/pr-workflow-example).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.270` -> `==0.0.272` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272)  #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4917 ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@density](https://togithub.com/density) in [astral-sh/ruff#4884 ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4942 - Skip class scopes when resolving nonlocal references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4943 - Apply `dict.get` fix before ternary rewrite by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4944 - Handle implicit string concatenations in conversion-flag rewrites by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4947 - Make `C413` fix as suggested for `reversed` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4891 - ignore if using infinite iterators in `B905` by [@kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#4914 **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.270` -> `==0.0.272` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272)  #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4917 ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@density](https://togithub.com/density) in [astral-sh/ruff#4884 ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4942 - Skip class scopes when resolving nonlocal references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4943 - Apply `dict.get` fix before ternary rewrite by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4944 - Handle implicit string concatenations in conversion-flag rewrites by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4947 - Make `C413` fix as suggested for `reversed` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4891 - ignore if using infinite iterators in `B905` by [@kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#4914 **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Fix UP036 auto-fix error

bf691ff

JonathanPlasse commented May 27, 2023

View reviewed changes

Add comment

fef4d80

charliermarsh reviewed May 27, 2023

View reviewed changes

JonathanPlasse and others added 2 commits May 27, 2023 23:21

Fix another auto-fix error and simplify logic

8d37349

Merge branch 'main' into fix-up036-auto-fix-error

39152d7

charliermarsh enabled auto-merge (squash) May 28, 2023 03:32

charliermarsh added bug Something isn't working fixes Related to suggested fixes for violations labels May 28, 2023

charliermarsh merged commit 9f16ae3 into astral-sh:main May 28, 2023
14 checks passed

JonathanPlasse deleted the fix-up036-auto-fix-error branch May 28, 2023 05:22

chenrui333 mentioned this pull request Jun 6, 2023

ruff 0.0.272 Homebrew/homebrew-core#133013

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix UP036 auto-fix error #4679

Fix UP036 auto-fix error #4679

JonathanPlasse commented May 27, 2023

JonathanPlasse May 27, 2023

github-actions bot commented May 27, 2023 •

edited

charliermarsh May 27, 2023

JonathanPlasse May 27, 2023

Fix UP036 auto-fix error #4679

Fix UP036 auto-fix error #4679

Conversation

JonathanPlasse commented May 27, 2023

Summary

Test Plan

JonathanPlasse May 27, 2023

Choose a reason for hiding this comment

github-actions bot commented May 27, 2023 • edited

PR Check Results

Ecosystem

Benchmark

Linux

Windows

charliermarsh May 27, 2023

Choose a reason for hiding this comment

JonathanPlasse May 27, 2023

Choose a reason for hiding this comment

github-actions bot commented May 27, 2023 •

edited