[`flake8-pyi`] Add `PYI032` rule with autofix #4695

qdegraaf · 2023-05-28T17:14:18Z

Summary

Adds Y032 rule from flake8-pyi (https://github.com/PyCQA/flake8-pyi) to the Ruff plugin. Original rule definition:

The second argument of an eq or ne method should usually be annotated with object rather than Any.

Test Plan

Fixtures for .py and .pyi added and added both cases to existing flake8-pyi unit tests

Issue link

Refers: #848

qdegraaf · 2023-05-28T17:15:44Z

crates/ruff/src/rules/flake8_pyi/rules/any_eq_ne_annotation.rs

+                );
+                if checker.patch(diagnostic.kind.rule()) {
+                    // def __eq__(self, arg2: Any): ...
+                    if let Some(name) = annotation.as_name_expr() {


I tried combining this logic with the the checker logic from lines 64-66 in a more efficient and elegant manner. Did not succeed in finding a better way, though I believe there are many ways to Rome here, so welcome any advice on making this patch more compact.

Hmm -- is there any issue with just using the range of the annotation? Why do we need to match on the "kind"?

Ah I see what I missed now. Tried that first, but could not get it to work. But I forgot to import: use ruff_python_ast::prelude::Ranged;

Thanks for edits!

github-actions · 2023-05-28T17:53:04Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     19.3±0.84ms     2.1 MB/sec    1.01     19.5±0.52ms     2.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.5±0.14ms     3.7 MB/sec    1.01      4.6±0.22ms     3.7 MB/sec
linter/all-rules/numpy/globals.py          1.00   555.5±19.52µs     5.3 MB/sec    1.02   566.4±29.31µs     5.2 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.0±0.29ms     3.2 MB/sec    1.00      8.0±0.28ms     3.2 MB/sec
linter/default-rules/large/dataset.py      1.05      9.0±0.27ms     4.5 MB/sec    1.00      8.6±0.32ms     4.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.09      2.0±0.08ms     8.3 MB/sec    1.00  1854.2±53.90µs     9.0 MB/sec
linter/default-rules/numpy/globals.py      1.04   238.5±26.45µs    12.4 MB/sec    1.00   229.6±12.19µs    12.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.1±0.15ms     6.3 MB/sec    1.02      4.1±0.17ms     6.2 MB/sec
parser/large/dataset.py                    1.00      6.8±0.15ms     6.0 MB/sec    1.01      6.9±0.14ms     5.9 MB/sec
parser/numpy/ctypeslib.py                  1.00  1355.3±52.23µs    12.3 MB/sec    1.02  1381.3±43.99µs    12.1 MB/sec
parser/numpy/globals.py                    1.00    138.4±6.23µs    21.3 MB/sec    1.00    137.9±5.28µs    21.4 MB/sec
parser/pydantic/types.py                   1.00      3.0±0.07ms     8.6 MB/sec    1.01      3.0±0.09ms     8.5 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     20.4±0.97ms  2039.3 KB/sec    1.02     20.8±1.06ms  2007.0 KB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      5.1±0.27ms     3.3 MB/sec    1.04      5.3±0.43ms     3.1 MB/sec
linter/all-rules/numpy/globals.py          1.00   603.7±35.11µs     4.9 MB/sec    1.04   628.5±34.21µs     4.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.5±0.44ms     3.0 MB/sec    1.02      8.6±0.39ms     3.0 MB/sec
linter/default-rules/large/dataset.py      1.00     10.1±0.46ms     4.0 MB/sec    1.02     10.3±0.43ms     4.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.2±0.16ms     7.7 MB/sec    1.02      2.2±0.17ms     7.6 MB/sec
linter/default-rules/numpy/globals.py      1.00   243.8±13.78µs    12.1 MB/sec    1.09   264.5±19.74µs    11.2 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.5±0.34ms     5.7 MB/sec    1.02      4.6±0.23ms     5.5 MB/sec
parser/large/dataset.py                    1.00      7.7±0.29ms     5.3 MB/sec    1.24      9.5±0.44ms     4.3 MB/sec
parser/numpy/ctypeslib.py                  1.00  1494.7±96.66µs    11.1 MB/sec    1.18  1768.5±84.06µs     9.4 MB/sec
parser/numpy/globals.py                    1.00   159.6±20.05µs    18.5 MB/sec    1.08   172.4±12.80µs    17.1 MB/sec
parser/pydantic/types.py                   1.00      3.4±0.16ms     7.6 MB/sec    1.18      4.0±0.35ms     6.4 MB/sec

charliermarsh · 2023-05-28T22:33:31Z

Thanks!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `^0.0.270` -> `^0.0.271` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.271`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).  Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `0.0.270` -> `0.0.272` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272)  #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4917 ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@density](https://togithub.com/density) in [astral-sh/ruff#4884 ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4942 - Skip class scopes when resolving nonlocal references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4943 - Apply `dict.get` fix before ternary rewrite by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4944 - Handle implicit string concatenations in conversion-flag rewrites by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4947 - Make `C413` fix as suggested for `reversed` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4891 - ignore if using infinite iterators in `B905` by [@kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#4914 **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/jankatins/pr-workflow-example).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.270` -> `==0.0.272` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272)  #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4917 ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@density](https://togithub.com/density) in [astral-sh/ruff#4884 ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4942 - Skip class scopes when resolving nonlocal references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4943 - Apply `dict.get` fix before ternary rewrite by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4944 - Handle implicit string concatenations in conversion-flag rewrites by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4947 - Make `C413` fix as suggested for `reversed` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4891 - ignore if using infinite iterators in `B905` by [@kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#4914 **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.270` -> `==0.0.272` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272)  #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4917 ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@density](https://togithub.com/density) in [astral-sh/ruff#4884 ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4942 - Skip class scopes when resolving nonlocal references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4943 - Apply `dict.get` fix before ternary rewrite by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4944 - Handle implicit string concatenations in conversion-flag rewrites by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4947 - Make `C413` fix as suggested for `reversed` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4891 - ignore if using infinite iterators in `B905` by [@kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#4914 **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

qdegraaf added 6 commits May 28, 2023 19:09

Add boilerplate and fixtures

5231dff

Add docs, add registry, add first steps to functionality

591d82c

Fix violation logic

5d234dd

Add autofix logic

b7e4585

cargo insta review

4049c30

Update ruff.schema.json

20d39ba

qdegraaf commented May 28, 2023

View reviewed changes

qdegraaf added 3 commits May 28, 2023 19:18

Add ... to docs

6b00fc0

Add indent to ...

7f69c5b

Add \n to docs

236fd55

Tweak docs; shuffle around some calls

3e0e6c8

charliermarsh added the rule Implementing or modifying a lint rule label May 28, 2023

charliermarsh changed the title ~~Add PYI032 rule with autofix~~ [flake8-pyi] Add PYI032 rule with autofix May 28, 2023

charliermarsh enabled auto-merge (squash) May 28, 2023 22:32

charliermarsh merged commit 0911ce4 into astral-sh:main May 28, 2023
14 checks passed

chenrui333 mentioned this pull request Jun 6, 2023

ruff 0.0.272 Homebrew/homebrew-core#133013

Merged

qdegraaf deleted the feature/PYI032 branch July 6, 2023 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[`flake8-pyi`] Add `PYI032` rule with autofix #4695

[`flake8-pyi`] Add `PYI032` rule with autofix #4695

qdegraaf commented May 28, 2023

qdegraaf May 28, 2023

charliermarsh May 28, 2023

qdegraaf May 29, 2023

github-actions bot commented May 28, 2023 •

edited

charliermarsh commented May 28, 2023

[flake8-pyi] Add PYI032 rule with autofix #4695

[flake8-pyi] Add PYI032 rule with autofix #4695

Conversation

qdegraaf commented May 28, 2023

Summary

Test Plan

Issue link

qdegraaf May 28, 2023

Choose a reason for hiding this comment

charliermarsh May 28, 2023

Choose a reason for hiding this comment

qdegraaf May 29, 2023

Choose a reason for hiding this comment

github-actions bot commented May 28, 2023 • edited

PR Check Results

Ecosystem

Benchmark

Linux

Windows

charliermarsh commented May 28, 2023

[`flake8-pyi`] Add `PYI032` rule with autofix #4695

[`flake8-pyi`] Add `PYI032` rule with autofix #4695

github-actions bot commented May 28, 2023 •

edited