-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modules listed in transpilers should implicitly be allowUnsued #18
Comments
I'd be fine with that. The build script should allow dependency-lint to see its use, but this sounds correct in the case that the user hasn't added a build script yet. |
Yeah, that's a good point. This mostly came about from @kevgo's new convention of not using npm's |
For shell scripts, dependency lint could just search for the executable in the file. Could be new options |
+1 on |
Added in the ability to search shell scripts for module executables. Since that lack was the original reason for this request, can you try that out and see if this is still needed? |
@alexdavid any thoughts on my previous comment? |
I haven't had a chance to try this out yet since I've been using package.json scripts. @kevgo uses shell scripts though. Have you had a chance to try this out Kevin? |
That seems to work well. Thanks! |
Closing this out as it appears to be resolved. Please reopen if you want to discuss more |
If I am building my project in a compile-to-js language, I'm probably going to want that package as a devDependency for my build script, but I'm most likely not going to be requiring it anywhere in my project.
I think dependency lint should automatically include any modules listed under transpilers in the
allowUnused
section.Thoughts?
The text was updated successfully, but these errors were encountered: