Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules listed in transpilers should implicitly be allowUnsued #18

Closed
alexdavid opened this issue Feb 16, 2016 · 9 comments
Closed

Modules listed in transpilers should implicitly be allowUnsued #18

alexdavid opened this issue Feb 16, 2016 · 9 comments

Comments

@alexdavid
Copy link
Contributor

If I am building my project in a compile-to-js language, I'm probably going to want that package as a devDependency for my build script, but I'm most likely not going to be requiring it anywhere in my project.

I think dependency lint should automatically include any modules listed under transpilers in the allowUnused section.

Thoughts?

@charlierudolph
Copy link
Owner

I'd be fine with that. The build script should allow dependency-lint to see its use, but this sounds correct in the case that the user hasn't added a build script yet.

@alexdavid
Copy link
Contributor Author

Yeah, that's a good point. This mostly came about from @kevgo's new convention of not using npm's scripts block, but instead using shell scripts in bin/

@charlierudolph
Copy link
Owner

For shell scripts, dependency lint could just search for the executable in the file. Could be new options shellScriptPatterns and devShellScriptPatterns.

@kevgo
Copy link
Contributor

kevgo commented Feb 16, 2016

+1 on shellScriptPatterns

@charlierudolph
Copy link
Owner

Added in the ability to search shell scripts for module executables. Since that lack was the original reason for this request, can you try that out and see if this is still needed?

@charlierudolph
Copy link
Owner

@alexdavid any thoughts on my previous comment?

@alexdavid
Copy link
Contributor Author

I haven't had a chance to try this out yet since I've been using package.json scripts. @kevgo uses shell scripts though. Have you had a chance to try this out Kevin?

@kevgo
Copy link
Contributor

kevgo commented Jul 6, 2016

That seems to work well. Thanks!

@charlierudolph
Copy link
Owner

Closing this out as it appears to be resolved. Please reopen if you want to discuss more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants