Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customized Styles #33

Closed
enigmablue opened this issue Jun 13, 2020 · 4 comments · Fixed by #35
Closed

Customized Styles #33

enigmablue opened this issue Jun 13, 2020 · 4 comments · Fixed by #35
Labels
good first issue

Comments

@enigmablue
Copy link

Hi i believe i need a way where the controls can be moved higher. Can you enable a props for that please? Right now its too low and clashing on a text overlay i have

image

Originally posted by @enigmablue in #27 (comment)
@enigmablue
Copy link
Author

still no way for this zz

@charliesbot
Copy link
Owner

hey, I'll take a look. I'm on vacations and I don't have my personal mac with me.
If you are in a rush, feel free to open a PR, this will involve adding a prop that receives a style object. I'll check your PR for sure! :)

Otherwise, I'll have my mac again in two weeks 💻

@enigmablue
Copy link
Author

hey sorry. haha i'm quite bad at updating external packages esp i think its on typescript? i can ask around to see if i can get some help. Hope your mac gets back soon!

@charliesbot
Copy link
Owner

I’m available if you need any help!

@charliesbot charliesbot mentioned this issue Jul 5, 2020
Merged
@enigmablue enigmablue mentioned this issue Aug 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support custom style for slider charliesbot/react-native-media-controls
2 participants
@charliesbot @enigmablue