Customized Style?

[enigmablue]

Hi mate,

I had to fork this to fix two issues, one was that start and end time (which i think you fixed in the latest). fixed by adding date.setMinutes(0); date.setHours(0);

But also the style where the controls had some align issue.

I had to manually increase a marginBottom: -150 to the mediacontrols.style.ts

But i much prefer not to fork and have a custom git (as it causes issues to my yarn).
Wonder if we can fix it here and have the styles in the ?

[charliesbot]

I haven’t seen those UI issues. Do you have an example that I can see?

And yeah, the issue about the wrong times is already fixed in the latest release 👌

[enigmablue]

hey Charlie thanks. I checked the latest and it looks better somehow. But i do have a problem when i can't move the bar it clashes with my other component :( which causes the control to not be usable. I do have a button below it unfortunately so i can't really move that text down easily.

My other problem was that the controls show up automatically default to true. I had to change that to false in mediacontrols.tsx

const [opacity] = useState(new Animated.Value(0));
const [isVisible, setIsVisible] = useState(false);

[enigmablue]

the last thing is when the video is set to repeat true, the controls does not restart when the video repeats.

[charliesbot]

@enigmablue do you have an example that I can replicate? I would need to recreate this, because from the screenshot it looks to me that you wrapped this component in a flexbox container.

I do need a code example to debug this.

Regarding the last comment, in version 2.0.3 you can do that with the prop showOnStart={false}

What do you mean by "the controls doesn't restart"?

[enigmablue]

hey Charlie, thanks for this. Unfortunately, my codebase is quite big and to strip out everything is going to take a bit of time. I"m going to see if i can rearrange my UI and use the showOnStart. And if i can get to creating a simpler code base i'd share it.

…

On Fri, May 22, 2020 at 9:15 PM Charlie ***@***.***> wrote: @enigmablue <https://github.com/enigmablue> do you have an example that I can replicate? I would need to recreate this, because from the screenshot it looks to me that you wrapped this component in a flexbox container. I do need a code example to debug this. Regarding the last comment, in version 2.0.3 you can do that with the prop showOnStart={false} — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIPPQVLLVMRN6Z7Z46U473TRSZ3HXANCNFSM4NFRBRZA> .

[enigmablue]

Hi Charlie, i created a code example that you can try to debug this. Its quite basic. one thing to note its within a native-base component hmm.

Also one thing to note that you will see, when the video is repeat = {true} the controls dosen't reset. I dont know how to make that work either.

https://github.com/enigmablue/mediasample

[charliesbot]

thanks for the sample! Will take a look

[charliesbot]

ok, I took a look into your question about the controls that doesn't change if you use repeat in the video player.

Please notice that this library is just a UI overlay on top of any player. That means that I don't control how the controls behave, that's on your side.

I added more cases in the example project (PR -> #32).

If you enable the repeat option, that means you don't need the state ENDED, as you will never reach it. Based on that, I just removed that line in the onEnd event.

[enigmablue]

Please notice that this library is just a UI overlay on top of any player. That means that I don't control how the controls behave, that's on your side.

thanks man. I appreciate that. Its also with your help on mentioning those cases that helps us to understand how to manage / use the controls better. Thanks!