Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amplifier module #5

Merged
merged 7 commits into from
Apr 3, 2020
Merged

Amplifier module #5

merged 7 commits into from
Apr 3, 2020

Conversation

jacobh
Copy link
Collaborator

@jacobh jacobh commented Apr 3, 2020

No description provided.

@jacobh
Copy link
Collaborator Author

jacobh commented Apr 3, 2020

actually I'll implement modulation before we merge this

haileys
haileys reviewed Apr 3, 2020
View reviewed changes
Copy link
Owner

@haileys haileys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor things but looks good otherwise!

src/module/mixer_2ch.rs Outdated Show resolved Hide resolved
src/module/amplifier.rs Outdated Show resolved Hide resolved
jacobh and others added 2 commits April 3, 2020 16:12
@jacobh
Input typo
c88ac0f 
Co-Authored-By: Charlie Somerville <charlie@charlie.bz>
@jacobh
Fix depth typo
6ba66ec 
Co-Authored-By: Charlie Somerville <charlie@charlie.bz>
@jacobh
Copy link
Collaborator Author

jacobh commented Apr 3, 2020

cool, fixed those up (that suggestions feature is nice)

@haileys haileys merged commit 32f41d2 into haileys:master Apr 3, 2020
@jacobh jacobh deleted the jacobh/amplifier branch April 3, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileys haileys haileys left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobh @haileys