Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion in test using Japanese Windows XP / Ruby Installer #5

Closed
fritzsche opened this issue Jan 14, 2012 · 2 comments
Closed

Assertion in test using Japanese Windows XP / Ruby Installer #5

fritzsche opened this issue Jan 14, 2012 · 2 comments

Comments

@fritzsche
Copy link
Contributor

Hi Charlie,

after fix reported in issue #4 I can run the test suite but still have 2 assertions as shown below.
I understand that windows might not be in focus on this early stage of development but any ideas?

Thanks, Thomas

...................................
test/exceptions.js
FAIL finally still executes if catch throws an exception and the exception keeps bubbling up
Assertion failed after 0 assertions:
....................................................
test/semicolon_insertion.js
FAIL return is greedily semicolon inserted
Assertion failed after 0 assertions: !== <1>
.............................................................................................Coverage report generated for test.rb to D:/Rails/twostroke/coverage. 2621 / 2742 LOC (95.59%) covered.

@haileys
Copy link
Owner

haileys commented Jan 15, 2012

I shouldn't say that those failures are supposed to be happening, but I do know about them and it isn't any of your fault.

One's for an edge case with exceptions that I have to fix, the other is a reminder for me to implement semicolon insertion.

I'll leave this ticket open until I fix that

@haileys
Copy link
Owner

haileys commented Jan 20, 2012

All tests are passing now!

@haileys haileys closed this as completed Jan 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants