Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(textinput): expose matched suggestions and index #556

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luevano
Copy link

@luevano luevano commented Jul 17, 2024

In its current state, if I want to get the matched suggestions (and their index) I need to recalculate that myself when the bubble already does this for free (as in already available). This allows to use the matching suggestions data to display any sort of custom views.

For example, in its current state, if I want to list the suggestions I only have access to the Available ones, and this is all I can display (without recalculating myself):
image
image

With these exposed methods, now I can display more "complex" views, such as:
image

Pardon the styling, just a placeholder.

@meowgorithm
Copy link
Member

Good call; I believe this makes sense.

Fwiw, I think there are a lot of improvements that can happen to suggestions in general and I've been wondering if the API needs to be reexamined altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants