Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include command config option #81

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

isabelroses
Copy link
Contributor

closes #44

Co-authored-by: Swastik <swstkbaranwal@gmail.com>
@Delta456
Copy link

Should also close #76

@isabelroses
Copy link
Contributor Author

Example outputs

ex1

ex2

@maaslalani
Copy link
Member

Hey @isabelroses, this is an awesome PR:

I think it would benefit from a few changes:

  1. Let's prefix the option with --execute. so it's logically grouped with the execute functionality.

  2. I think it can be on by default, what do you think? i.e. opt-out --execute.command=false (maybe --execute.show-command?)

  3. Change the prompt to > to match VHS, we use:

PS1=\\[\\e[38;2;90;86;224m\\]> \\[\\e[0m\\]

@isabelroses
Copy link
Contributor Author

So after making the suggested changes the outputs have changed from before, somehow the eza's output has ended up shifted
out2
test

@isabelroses
Copy link
Contributor Author

So after making the suggested changes the outputs have changed from before, somehow the eza's output has ended up

Realised this might be because since the start of this PR I installed libsvg.

@maaslalani
Copy link
Member

freeze

@maaslalani
Copy link
Member

I believe it could be because of the font, since it's not a monospace font, it looks like.

@isabelroses
Copy link
Contributor Author

I believe it could be because of the font, since it's not a monospace font, it looks like.

Ahh good call this is on WSL.

@4zv4l
Copy link

4zv4l commented May 27, 2024

Hi, any update on this ? Do we know when it would be merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: plot the command along with the result
4 participants