Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace TableWriter with lipgloss table #254

Open
bashbunni opened this issue Sep 1, 2023 · 3 comments · May be fixed by #262
Open

refactor: replace TableWriter with lipgloss table #254

bashbunni opened this issue Sep 1, 2023 · 3 comments · May be fixed by #262
Assignees
Labels
enhancement New feature or request

Comments

@bashbunni
Copy link
Member

Depends on this PR in Lipgloss charmbracelet/lipgloss#218
Would simplify the implementation of our current table rendering solution

@bashbunni bashbunni added the enhancement New feature or request label Sep 1, 2023
@bashbunni bashbunni self-assigned this Sep 1, 2023
@meowgorithm
Copy link
Member

meowgorithm commented Sep 1, 2023

Lip Gloss table is pretty close, I think, so I imagine we can get it in not too long after Maas gets back. The width settings on the table actually came from the goal of implementing it into Glamour.

@maxmoehl
Copy link

Would this help resolve #247 or is that a different issue?

@bashbunni
Copy link
Member Author

hey @maxmoehl this change should fix a lot of the issues currently have open for glamour tables. That one included

@bashbunni bashbunni linked a pull request Apr 4, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants