Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gum filter --reverse #114

Closed
caarlos0 opened this issue Aug 9, 2022 · 3 comments · Fixed by #177
Closed

gum filter --reverse #114

caarlos0 opened this issue Aug 9, 2022 · 3 comments · Fixed by #177
Labels
enhancement New feature or request

Comments

@caarlos0
Copy link
Member

caarlos0 commented Aug 9, 2022

Is your feature request related to a problem? Please describe.
fzf's default style is prompt in the bottom, list in the top... gum's is the other way around.,

Describe the solution you'd like
fzf also has a --layout reverse flag to make it the other way around... I believe we need something like that in for gum filter too.

Describe alternatives you've considered
haven't found any alternatives

Additional context

@maaslalani
Copy link
Member

TIL about fzf --layout reverse! Yeah, we can have something similar in Gum :)

@meowgorithm meowgorithm added the enhancement New feature or request label Sep 14, 2022
@dhruvmanila
Copy link
Contributor

fzf offers multiple layouts:

*        --layout=LAYOUT
*               Choose the layout (default: default)
  
                default       Display from the bottom of the screen
                reverse       Display from the top of the screen
                reverse-list  Display from the top of the screen, prompt at the bottom

The default for gum is the reverse layout. By reverse, @caarlos0 do you mean the default layout?

@caarlos0
Copy link
Member Author

caarlos0 commented Oct 3, 2022

The default for gum is the reverse layout. By reverse, @caarlos0 do you mean the default layout?

yes, so, my suggestion is to add the "alternate" layout, do we can have a --reverse flag as well... but in gum's case, gum's default == fzf's --reverse, and gum's --reverse == fzf's default.l

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants