Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): add reverse layout #177

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

dhruvmanila
Copy link
Contributor

resolves: #114

Changes

Add --reverse flag to gum filter command to display the list in reverse direction similar to the default layout for fzf

filter_reverse

@muesli muesli added the enhancement New feature or request label Oct 6, 2022
@maaslalani
Copy link
Member

Hey, this looks almost good to go. One last case we need to handle is when you are in --reverse and scroll up past the viewport and then filter (by typing more text) the cursor will be off the screen. We would need to clamp it to be inside the viewport.

To reproduce:

gum filter --reverse --height 10

Press Up 20 times

Type: Dock

The cursor will be off the screen

@maaslalani maaslalani merged commit a82d5af into charmbracelet:main Oct 7, 2022
@maaslalani
Copy link
Member

Awesome work @dhruvmanila, thank you so much for the contribution!

@dhruvmanila dhruvmanila deleted the feat/filter-reverse branch October 7, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gum filter --reverse
3 participants