Skip to content

Commit

Permalink
fix: code review suggestions
Browse files Browse the repository at this point in the history
Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>
Co-authored-by: bashbunni <15822994+bashbunni@users.noreply.github.com>
  • Loading branch information
3 people committed Apr 18, 2024
1 parent f450785 commit 14ef502
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions list/enumerations.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ func Asterisk(Data, int) string {

// Dash is an enumeration using dashes.
//
// * Foo
// * Bar
// * Baz
// * Qux.
// - Foo
// - Bar
// - Baz
// - Qux.
func Dash(Data, int) string {
return "-"
}
6 changes: 3 additions & 3 deletions tree/item.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ type Filter struct {
filter func(index int) bool
}

// Append implements Data.
// Append allows Filter to implement Data. It adds an element to the Tree.
func (m *Filter) Append(item Node) Data {
m.data = m.data.Append(item)
return m
Expand All @@ -70,7 +70,7 @@ func NewFilter(data Data) *Filter {
return &Filter{data: data}
}

// Remove implements Data.
// Remove allows Filter to implement Data. It removes an element from the Tree.
func (m *Filter) Remove(index int) Data {
m.data = m.data.Remove(index)
return m
Expand All @@ -92,7 +92,7 @@ func (m *Filter) At(index int) Node {
return nil
}

// Filter applies the given filter function to the data.
// Filter uses a filter function to set a condition that all the data must satisfy to be in the Tree.
func (m *Filter) Filter(f func(index int) bool) *Filter {
m.filter = f
return m
Expand Down

0 comments on commit 14ef502

Please sign in to comment.