fix: remove Append from Data (make it optional)

charmbracelet · Oct 5, 2023 · f184359 · f184359
1 parent e26eec2
commit f184359
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/table/rows.go b/table/rows.go
@@ -3,7 +3,6 @@ package table
 // Data is the interface that wraps the basic methods of a table model.
 type Data interface {
 	Row(row int) Row
-	Append(row Row)
 	Count() int
 	Columns() int
 }
@@ -110,11 +109,6 @@ func (m *Filter) Row(row int) Row {
 	return nil
 }
 
-// Append appends the given row to the table.
-func (m *Filter) Append(row Row) {
-	m.data.Append(row)
-}
-
 // Columns returns the number of columns in the table.
 func (m *Filter) Columns() int {
 	return m.data.Columns()

diff --git a/table/table.go b/table/table.go
@@ -115,7 +115,10 @@ func (t *Table) Rows(rows ...[]string) *Table {
 		t.data = NewStringData()
 	}
 	for _, row := range rows {
-		t.data.Append(StringRow(row))
+		switch t.data.(type) {
+		case *StringData:
+			t.data.(*StringData).Append(StringRow(row))
+		}
 	}
 	return t
 }
@@ -125,7 +128,10 @@ func (t *Table) Row(row ...string) *Table {
 	if t.data == nil {
 		t.data = NewStringData()
 	}
-	t.data.Append(StringRow(row))
+	switch t.data.(type) {
+	case *StringData:
+		t.data.(*StringData).Append(StringRow(row))
+	}
 	return t
 }