feat: use tree impl for lists #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
An empty string could not have padding applied on the right side. Issue: #252 Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
Apply gofumpt to all files to correct minor formatting issues. Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
The `padLeft` and `padRight` functions were nearly identical and could benefit from being refactored to share common code. A new function called `pad` was added that applies padding based on the sign of the amount of padding needed. A positive value applies padding to the right side while a negative value applies padding to the left side. Issue: #252 Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
The function `maxRuneWidth` was using a flawed approach by only evaluating strings based on each rune. The `uniseg` package provides a more accurate method based on grapheme clusters. This change switches over to the improved implementation which should achieve better results when determining the maximum width of all grapheme clusters in a string. Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
I call this "the frankenlistre"
|
|
todo
|
Merged
|
superseeded by #264 |
|
closing in favor of #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will use the tree renderer to render lists too.
Both are very similar if you think about it, the only difference is how they are displayed.
I ended up moving a lot of stuff around, and removing some other things - mainly filter, hide, etc, which I think are more behavior-related than styling, so maybe they should be in the bubble that uses list instead of here?
Anyway, let me know what you think!
PS: all tests are creating golden files, which you can inspect to see how the output looks like :)