Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to term/ansi for text manipulation #268

Merged
merged 2 commits into from Mar 29, 2024
Merged

Conversation

aymanbagabas
Copy link
Member

@aymanbagabas aymanbagabas commented Mar 14, 2024

Use ANSI aware, wide characters support, uniseg backed term/ansi package to calculate string widths, truncate, and wrap strings.

Related: muesli/reflow#71
Fixes: #258
Related: #220

Copy link
Contributor

@mikelorant mikelorant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except the confusion caused by the commented out line.

join.go Outdated Show resolved Hide resolved
@aymanbagabas aymanbagabas force-pushed the use-ansi branch 4 times, most recently from caab99b to e28ab39 Compare March 28, 2024 15:12
Use ANSI aware, wide characters support, uniseg backed term/ansi package
to calculate string widths, truncate, and wrap strings.

Related: muesli/reflow#71
Fixes: #258
Fixes: #220
get.go Outdated Show resolved Hide resolved
@aymanbagabas aymanbagabas merged commit f6f9334 into master Mar 29, 2024
18 checks passed
@aymanbagabas aymanbagabas deleted the use-ansi branch March 29, 2024 19:05
@mikelorant
Copy link
Contributor

@aymanbagabas We need Bubbles to be updated ASAP as this will cause major inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"nonspacing mark" unicode causes container's width to shift
3 participants