fix: lazy init default logger #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default logger will try to query background et al on startup, which might conflict with other libs trying to query it too. It's easily reproducible with some of our tools that use the log package, e.g., VHS: ```sh faketty vhs --help ``` It slows down the program quite a bit, and print some ansi escape sequences as well. This patch changes it so it only inits the default logger when/if the default logger is used. Per my testing, it seems to fix the original issue.
|
PS: this is not a |
caarlos0
added a commit
to charmbracelet/freeze
that referenced
this pull request
Mar 4, 2024
refs charmbracelet/log#111 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
caarlos0
added a commit
to charmbracelet/mods
that referenced
this pull request
Mar 4, 2024
refs charmbracelet/log#111 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
caarlos0
added a commit
to charmbracelet/vhs
that referenced
this pull request
Mar 4, 2024
refs charmbracelet/log#111 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
This was referenced Mar 4, 2024
caarlos0
added a commit
to charmbracelet/vhs
that referenced
this pull request
Mar 4, 2024
refs charmbracelet/log#111 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default logger will try to query background et al on startup, which might conflict with other libs trying to query it too.
It's easily reproducible with some of our tools that use the log package, e.g., VHS:
It slows down the program quite a bit, and print some ansi escape sequences as well.
This patch changes it so it only inits the default logger when/if the default logger is used.
Per my testing, it seems to fix the original issue.