Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chat completion return error for stream clients #270

Closed

Conversation

PylotLight
Copy link

Updated StreamReader Close() returns with error type and and connected dependencies.
Tested building and running of the cli which seems to work on my machine.

Note: these changes were required to get the cli to work on my machine, not sure if there's a better solution but it works for me and thought I'd get someone to look over it.

@PylotLight PylotLight requested a review from caarlos0 as a code owner May 24, 2024 10:03
@PylotLight
Copy link
Author

This PR is intended to address this issue: #269

caarlos0 added a commit that referenced this pull request May 24, 2024
closes #269
closes #270

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
Copy link
Member

reopened as #272

thanks for the nudge though 🙏

@PylotLight
Copy link
Author

That makes total sense. closing this one seeing you have your own official fixes on the way, cheers.
I'll try keep changes narrower in future.

@PylotLight PylotLight closed this May 24, 2024
caarlos0 added a commit that referenced this pull request May 24, 2024
* feat(deps): update openai

closes #269
closes #270

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: err handling

---------

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants