Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: context data race #4

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix: context data race #4

merged 1 commit into from
Jul 20, 2023

Conversation

aymanbagabas
Copy link
Member

Context may involve in a RW data race when setting and accessing a value and its done channel.

Fixes: gliderlabs#160

Context may involve in a RW data race when setting and accessing a value
and its done channel.

Fixes: gliderlabs#160
@aymanbagabas aymanbagabas merged commit 32c90e1 into merge-upstream Jul 20, 2023
@aymanbagabas aymanbagabas deleted the ctx-race-fix branch July 20, 2023 14:38
@wxiaoguang
Copy link

This fix is incomplete.

Every call to sshCtx.Context (including Err() and others) all causes Data Race.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants