Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bubbletea): stop window change watching loop after tea.Program stopped #145

Merged
merged 1 commit into from Jun 8, 2023
Merged

Conversation

LindsayZhou
Copy link
Contributor

No description provided.

@caarlos0
Copy link
Member

caarlos0 commented Jun 8, 2023

I imagine you're running multiple apps in the same session to bring this up, correct?

anyway, good catch, thanks!

@caarlos0 caarlos0 added the bug Something isn't working label Jun 8, 2023
@caarlos0 caarlos0 self-assigned this Jun 8, 2023
@caarlos0 caarlos0 self-requested a review June 8, 2023 14:40
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #145 (fc12bc0) into main (78e6bbd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   76.14%   76.14%           
=======================================
  Files          17       17           
  Lines         897      897           
=======================================
  Hits          683      683           
  Misses        160      160           
  Partials       54       54           

@caarlos0 caarlos0 merged commit e6e4f48 into charmbracelet:main Jun 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants