Updates for 1.16 #138
Merged
Updates for 1.16 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I built a v1.16.0-beta.1 snap with this and verified that the modified templates look correct - the apiVersion and selector fields are the only things that changed, and the selectors match the labels of the pod templates. I also grepped the templates for extensions/v1beta1, apps/v1beta1, and apps/v1beta2 and didn't see any others that were missed. It's not clear to me if you've tested this, but if you have, feel free to merge it. |
|
I have tested this. I verified that 1.16 failed before and works now. |
|
Good enough for me 👍 Thanks @hyperbolic2346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a patch function to update the api version. It also adds in the selector since apps/v1 requires it. I kept the list as small as possible to try and prevent inadvertent issues.