Update gcr.io image pattern to handle regions #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new ingress image registry is a region specific domain rather than k8s.gcr.io, and the pattern was missing it, leading to the registry config not being honored and the image being uploaded to rocks at the wrong path.
kwmonroe
approved these changes
Aug 6, 2020
|
Turns out this won't actually fix the issue I was hitting, since as @kwmonroe pointed out, the image in question was a static one rather than from a template, but I do think this is reasonable for future-proofing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ingress image registry is a region specific domain rather than k8s.gcr.io, and the pattern was missing it, leading to the registry config not being honored and the image being uploaded to rocks at the wrong path.