-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VXLAN support #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but would like one small improvement to config description to address possible user confusion from the original implementation.
cmd = ['ethtool', '-K', 'vxlan.calico', 'tx-checksum-ip-generic', | ||
'off'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any cost to doing this every hook, or should we try to be smarter and limit it to only install and machine restart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a time cost, of course, but not a huge one. Ideally we would do something smarter here, but I'm hopeful that this will only be a temporary workaround - one that we can remove after we upgrade to Calico 3.16.x.
https://bugs.launchpad.net/charm-calico/+bug/1900706