Add config options for Nvidia APT sources, keys, and packages #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsca
reviewed
Oct 7, 2021
| gpg_key = requests.get(formatted_key_url, proxies=proxies).text | ||
| import_key(gpg_key) | ||
|
|
||
| sources = config('nvidia_apt_sources').splitlines() |
There was a problem hiding this comment.
I'd suggest using .split() here like you do for the other fields to be more forgiving. It will split on any whitespace, including newlines, so will also support space-separated, which is easier to do from the CLI.
Suggested change
| sources = config('nvidia_apt_sources').splitlines() | |
| sources = config('nvidia_apt_sources').split() |
There was a problem hiding this comment.
You're gonna have to be more specific about what you want here. The default value for nvidia_apt_sources is:
deb https://nvidia.github.io/libnvidia-container/{id}{version_id}/$(ARCH) /
deb https://nvidia.github.io/nvidia-container-runtime/{id}{version_id}/$(ARCH) /
deb http://developer.download.nvidia.com/compute/cuda/repos/{id}{version_id_no_dot}/x86_64 /
If I .split() that, I get:
['deb', 'https://nvidia.github.io/libnvidia-container/{id}{version_id}/$(ARCH)', '/', 'deb', 'https://nvidia.github.io/nvidia-container-runtime/{id}{version_id}/$(ARCH)', '/', 'deb', 'http://developer.download.nvidia.com/compute/cuda/repos/{id}{version_id_no_dot}/x86_64', '/']
What do you want me to do with that?
There was a problem hiding this comment.
Oh shoot, I missed that. Nevermind, then.
johnsca
approved these changes
Oct 7, 2021
|
Cherry-picked to stable in 81b1bda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.launchpad.net/charm-containerd/+bug/1915361