Change charms to use juju-http{s}-proxy model settings #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added Jenkins Tests; #447 |
Added code to pull down https_proxy config and override any existing keys if they exist.
Added missing parenthesis which cause a crash at run-time.
Added proxy key configuration to override default proxy options. LP#:https://bugs.launchpad.net/charm-kubernetes-master/+bug/1831712
Added docs on how to update integration tests.
Removed comment block and change to exception statement.
VariableDeclared
force-pushed
the
pj/lp-1831712
branch
from
f8fd408
to
cb4a3ca
Compare
There is an issue where calling
config().update({val}) causes docker-relation-departed
to fail. Initial look into this does not reveal much.
But changing code to val = config() then updating does not
cause the issue.
Needs investigation, will write up notes.
Cynerva
reviewed
Jul 12, 2019
|
Does this support CIDR notation in juju-no-proxy? From the Juju docs:
Docker most likely does not understand CIDR notation in the NO_PROXY env var (most apps don't), meaning we'd have to expand it into individual IPs somewhere along the way. I'm looking at the definition of env_proxy_settings and it doesn't look like it expands them, so that leaves it as the responsibility of the caller to do so. |
Moved juju configuration check into the container runtime common layer.
|
Refactored and created another pull request on container-runtime-common |
VariableDeclared
changed the title
Corrected missing config() call.
VariableDeclared
changed the title
Changed precedence so that local charm config wins over juju-http-proxy config.
VariableDeclared
force-pushed
the
pj/lp-1831712
branch
from
58bbbe7
to
a2f7541
Compare
|
Changing to WIP as I just need to run the most recent changes through. |
VariableDeclared
changed the title
VariableDeclared
changed the title
VariableDeclared
changed the title
Cynerva
reviewed
Jul 18, 2019
Cynerva
reviewed
Jul 18, 2019
Cynerva
reviewed
Jul 18, 2019
Added check for juju-http{s} proxy to install
method.
Missed the HTTP note. Updated this for changed precedent.
|
Thanks, LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed charm to use juju-http{s}-proxy-settings when these keys are defined.
LP#1831712