Ensure charm only accesses local API server #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new LB support in #153 unintentionally changed the endpoint that the charm client uses to talk to the API server making it use the internal LB address instead of always talking to the API server locally. This introduced an issue during bootstrap where the initial local-only token would try to be used on other API servers and fail. Fixes [lp:1941763](https://bugs.launchpad.net/charm-kubernetes-master/+bug/1941763)
|
The runners are still down, but here's a test run I did locally against vSphere: https://pastebin.ubuntu.com/p/d7gRG92cB2/ |
Cynerva
suggested changes
Aug 26, 2021
There was a problem hiding this comment.
The failure I explored on MAAS, where internal_url referred to an hacluster VIP, had a chicken-and-egg scenario. Services like kube-scheduler could not start because the VIP didn't route to masters, but the VIP didn't route because pacemaker saw that services like kube-scheduler were down and it refused to route to failing units.
To address the scenario with hacluster, I think we need to go further and use local_url everywhere that internal_url was used previously. Not just for the admin token, but also for kube-scheduler, kube-controller-manager, and kube-proxy.
Cynerva
approved these changes
Aug 26, 2021
Cynerva
pushed a commit
that referenced
this pull request
Aug 26, 2021
* Ensure charm only accesses local API server The new LB support in #153 unintentionally changed the endpoint that the charm client uses to talk to the API server making it use the internal LB address instead of always talking to the API server locally. This introduced an issue during bootstrap where the initial local-only token would try to be used on other API servers and fail. Fixes [lp:1941763](https://bugs.launchpad.net/charm-kubernetes-master/+bug/1941763) * Ensure all local charm kubectl usage uses the local url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new LB support in #153 unintentionally changed the endpoint that the charm client uses to talk to the API server making it use the internal LB address instead of always talking to the API server locally. This introduced an issue during bootstrap where the initial local-only token would try to be used on other API servers and fail.
Fixes lp:1941763