Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set CSIMigrationAWS or CSIMigrationGCE on k8s 1.25+ #244

Merged
merged 1 commit into from Aug 30, 2022
Merged

Don't set CSIMigrationAWS or CSIMigrationGCE on k8s 1.25+ #244

merged 1 commit into from Aug 30, 2022

Conversation

Cynerva
Copy link
Contributor

@Cynerva Cynerva commented Aug 30, 2022

stonepreston
stonepreston approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@stonepreston stonepreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

addyess
addyess approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't LGTM because it's sad to see this go. But i will give my 👍🏻 as it is correct based on 1.25 changelog

@addyess addyess merged commit 06f01e1 into main Aug 30, 2022
@addyess addyess deleted the gkk/1.25-csimigration-depre branch August 30, 2022 19:20
Cynerva pushed a commit that referenced this pull request Aug 30, 2022
Don't set CSIMigrationAWS or CSIMigrationGCE on k8s 1.25+ (#244)
40c0975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonepreston stonepreston stonepreston approved these changes

@addyess addyess addyess approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@Cynerva @stonepreston @addyess