Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ssl passthrough configuration option for ingress #27

Merged
merged 3 commits into from Aug 28, 2019

Conversation

hyperbolic2346
Copy link
Contributor

Removed enable from config name to match ingress-ssl-chain-completion
Changed template over to match ingress-ssl-chain-completion
Copy link
Member

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My nakintosh says you missed a config name change.

reactive/kubernetes_worker.py Outdated Show resolved Hide resolved
Copy link
Member

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a sucker for handling similar config in a similar fashion, so thanks for these changes. LGTM!

@kwmonroe kwmonroe merged commit 199e415 into master Aug 28, 2019
@kwmonroe kwmonroe deleted the mwilson/ssl-passthrough branch August 28, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants