Tests for juju-http(s)-proxy environment variables #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-stokes
force-pushed
the
master
branch
2 times, most recently
from
e096727
to
dd7345b
Compare
VariableDeclared
force-pushed
the
pj/ck-charm-tests
branch
from
270f221
to
d8b3518
Compare
VariableDeclared
changed the title
VariableDeclared
changed the title
VariableDeclared
force-pushed
the
pj/ck-charm-tests
branch
from
87c56cd
to
9094cf2
Compare
VariableDeclared
changed the title
adam-stokes
reviewed
Jul 12, 2019
| from .base import ( | ||
| UseModel, | ||
| _juju_wait | ||
| ) |
There was a problem hiding this comment.
You dont need UseModel anymore and _juju_wait has moved to utils. There is a fixture named model in conftest.py so you just need to pass that into your tests
adam-stokes
reviewed
Jul 12, 2019
| from .base import ( | ||
| UseModel, | ||
| _juju_wait | ||
| ) |
adam-stokes
suggested changes
Jul 12, 2019
Added integration test for HTTP proxy config using the juju-http-proxy model settings. Need to add tests for https, containerd, and layer-docker.
Added integration tests to check if juju proxy keys exist and override defined proxy values on the application.
Added tests to check layer-docker, charm-docker, and charm-containerd for correct setting of HTTP(S) environment variables.
Added tests to check for removal of https keys, refactored code, and improved regex.
More refractoring, moved proxy out to resolve crashing issues. Tests should be good to go.
Added missing removal of kubernetes-worker runtime relation.
Fixed destroying model at end of test.
Fixed model destroy call.
Controller causes tests to error out because of a missing connection.
Corrected errors in Jenkinsfiles when referring to parameters and renamed files appropriately.
Removed UseModel for current model fixture, also moved _juju_wait to import from utils.py.
VariableDeclared
force-pushed
the
pj/ck-charm-tests
branch
from
9094cf2
to
7e0ed55
Compare
Minor changes to reverse checks for precedence.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to check layer-docker, charm-docker, and charm-containerd for correct setting of HTTP(S) environment variables.