Updated kubelet and kube-proxy integration tests #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d commandline arguments
addyess
commented
Dec 8, 2021
| @@ -53,7 +53,7 @@ def timeout_for_current_task(timeout): | |||
| asyncio task will be cancelled, and an asyncio.TimeoutError will be raised. | |||
| """ | |||
| loop = asyncio.get_event_loop() | |||
| task = asyncio.Task.current_task() | |||
| task = asyncio.current_task() | |||
There was a problem hiding this comment.
asyncio.Task.current_task() Deprecated in python 3.9
| @@ -924,21 +924,20 @@ async def run_extra_args_test(app_name, new_config, expected_args): | |||
| "kubelet-extra-args": " ".join( | |||
| [ | |||
| "v=1", # int arg, overrides a charm default | |||
| "add-dir-header", # bool arg, implied true | |||
| "alsologtostderr=false", # bool arg, explicit false | |||
| "log-flush-frequency=5s", # duration arg, explicitly 5s | |||
There was a problem hiding this comment.
I couldn't find an argument to kubelet that wasn't deprecated and was a single flag arg like add-dir-header these were my choices:
- azure-container-registry-config
- bootstrap-kubeconfig
- cert-dir
- exit-on-lock-contention
- hostname-override
- housekeeping-interval
- image-credential-provider-bin-dir
- image-credential-provider-config
- image-service-endpoint
- lock-file
- log-flush-frequency
- node-labels
- root-dir
- runtime-cgroups
- seccomp-default
- vmodule
kwmonroe
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
Thanks!
Fixes lp: https://bugs.launchpad.net/charmed-kubernetes-testing/+bug/1953633
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated kubelet and kube-proxy integration tests to use non-deprecated commandline arguments