Add VXLAN support #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsca
suggested changes
Oct 27, 2020
Comment on lines
+686
to
+687
| cmd = ['ethtool', '-K', 'vxlan.calico', 'tx-checksum-ip-generic', | ||
| 'off'] |
There was a problem hiding this comment.
Is there any cost to doing this every hook, or should we try to be smarter and limit it to only install and machine restart?
There was a problem hiding this comment.
There is a time cost, of course, but not a huge one. Ideally we would do something smarter here, but I'm hopeful that this will only be a temporary workaround - one that we can remove after we upgrade to Calico 3.16.x.
johnsca
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/charm-calico/+bug/1900706