Fix upgrade failure when leader is attached to k8s-master #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also would like to do some testing on this code. Can you please hold the merge until I do so? |
hyperbolic2346
approved these changes
Sep 24, 2019
|
Waiting to merge, see discussion in charmed-kubernetes/charm-calico#47 |
|
We're not willing to wait any longer to merge this. Merging. If you do encounter any issues in testing, let us know and we'll resolve it in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.launchpad.net/charm-canal/+bug/1844605
I tested this with two deployments. For the first one, I did a direct deployment of the canonical-kubernetes-canal bundle from edge using a locally built canal, and ensured that the canal leader was attached to a kubernetes-worker unit. I verified that all calico services, and in particular the calico policy controller, were running.
For the second one, I tried to mimick the bug's failure conditions by deploying canonical-kubernetes-canal-484, ensuring that the canal leader was attached to a kubernetes-master unit, and then upgrading canal. I verified that all calico services upgraded correctly and that I could create new pods after the upgrade.