Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subordinate container runtime #15

Merged
merged 10 commits into from Jun 20, 2019
Merged

Conversation

joedborg
Copy link
Contributor

Don't merge until we do all of the branches together.

@joedborg joedborg added the enhancement New feature or request label May 10, 2019
@joedborg joedborg requested a review from Cynerva May 10, 2019 13:35
@joedborg joedborg self-assigned this May 10, 2019
reactive/calico.py Outdated Show resolved Hide resolved
@joedborg
Copy link
Contributor Author

@Cynerva the cnx-manager pod is failing wit:

[ALERT] 143/154947 (1) : parsing [/usr/local/etc/haproxy/haproxy.cfg:47] : 'server static' : could not resolve address 'kubernetes.default'.
[ALERT] 143/154947 (1) : Failed to initialize server(s) addr.

Any idea if this is just because I'm not in a BGP environment or whether it's something I need to fix?

@Cynerva
Copy link
Contributor

Cynerva commented May 24, 2019

Any idea if this is just because I'm not in a BGP environment or whether it's something I need to fix?

Yeah, this is almost certainly because you don't have the proper cloud configuration for Tigera traffic. Looks like cnx-manager can't reach the coredns pod to do dns lookups.

reactive/calico.py Outdated Show resolved Hide resolved
reactive/calico.py Outdated Show resolved Hide resolved
reactive/calico.py Outdated Show resolved Hide resolved
for image in images:
CTL.pull(
registry + image,
)
Copy link
Contributor

@Cynerva Cynerva Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, over in charmed-kubernetes/charm-calico#36, you've added the calico-node-image resource as a workaround for the fact that CTL.pull does not respect the proxy configuration of the containerd subordinate. Correct?

So we'll need a similar workaround for the images here. But, using charm resources as a workaround here is more problematic because the cnx-node and calicoctl images used by this charm are protected proprietary images. We can't legally host them in the charm store. Which means the user would have to be responsible for manually attaching the images.

I think a different workaround will be necessary here.

Copy link
Contributor

@Cynerva Cynerva Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From IRC, the plan is to ship this with zero-byte resources in the charm store, and provide documentation for users to attach their own image as needed for offline deployments. Works for me.

wheelhouse.txt Outdated Show resolved Hide resolved
@joedborg joedborg merged commit 4295f53 into master Jun 20, 2019
@joedborg joedborg deleted the subordinate-container-runtime branch June 20, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants