Detect and handle changes in etcd info #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connection and cert info for etcd can change and needs to trigger the service config being updated and the service restarted.
Cynerva
reviewed
Jul 2, 2019
|
Tested as described in charmed-kubernetes/charm-kubernetes-control-plane#34 (comment) Ready for review. |
hyperbolic2346
approved these changes
Jul 15, 2019
Cynerva
pushed a commit
that referenced
this pull request
Jul 30, 2019
* Detect and handle changes in etcd info The connection and cert info for etcd can change and needs to trigger the service config being updated and the service restarted. * Ensure etcd creds are rewritten * Ensure NPC config gets updated with cert * Fix services not restarting on ca/etcd cert change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection and cert info for etcd can change and needs to trigger the service config being updated and the service restarted.