Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-leader units should be in idle rather than waiting on leadership #23

Merged
merged 1 commit into from Aug 12, 2022
Merged

non-leader units should be in idle rather than waiting on leadership #23

merged 1 commit into from Aug 12, 2022

Conversation

addyess
Copy link
Member

@addyess addyess commented Aug 12, 2022

Addresses LP#1903313

kwmonroe
kwmonroe approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, waiting was never correct here as followers weren't waiting on an admin to do anything. Active feels appropriate as non-followers are ready to jump as soon as the leader tells them how high.

@kwmonroe kwmonroe merged commit b91b33d into main Aug 12, 2022
@kwmonroe kwmonroe deleted the bugs/LP1903313 branch August 12, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwmonroe kwmonroe kwmonroe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@addyess @kwmonroe