Address LP#2033710 by improving the IP address parsing #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
commented
Sep 1, 2023
Comment on lines
+193
to
+194
| wait=wait_exponential(multiplier=1, min=2, max=15), | ||
| stop=stop_after_delay(60 * 5), |
There was a problem hiding this comment.
So long as the ApiError exception occurs, wait seconds (2, 4, 8, 15 .. 15 ... 15 ) for a maximum of 5m
addyess
force-pushed
the
akd/lp2033710/ipaddress-validation
branch
from
ae40b5b
to
d6ca786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP#2033710
When one configs the charm with a single ip address such as
iprange=192.168.0.1rather thaniprange=192.168.0.1/32-- the charm fails to deal with this config and attempts to set the bare address in thespec.addressesofmetallb.io/v1beta1/IPaddressPoolthis causes an API error 403 forbidden because values of
spec.addressesmust either be an address range or a cidr subnet, not a single valueA worse situation is the charm cannot recover because it retries forever rather than stopping with an eventual error.