Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle APIError when applying manifests #17

Merged
merged 7 commits into from
Dec 15, 2022
Merged

Handle APIError when applying manifests #17

merged 7 commits into from
Dec 15, 2022

Conversation

mateoflorido
Copy link
Member

Issue

When trying to deploy the vSphere-Cloud-Provider charm using the following overlay:

description: Charmed Kubernetes overlay to add native vSphere support.
applications:
  kubernetes-control-plane:
    options:
      allow-privileged: "true"
  vsphere-integrator:
    charm: vsphere-integrator
    num_units: 1
    trust: true
  vsphere-cloud-provider:
    charm: vsphere-cloud-provider
relations:
- - vsphere-cloud-provider:certificates
  - easyrsa:client
- - vsphere-cloud-provider:kube-control
  - kubernetes-control-plane:kube-control
- - vsphere-cloud-provider:external-cloud-provider
  - kubernetes-control-plane:external-cloud-provider
- - vsphere-cloud-provider:vsphere-integration
  - vsphere-integrator:clients

Changes

  • Handle the APIError exception and set the unit state accordingly.

Further Information

src/charm.py Outdated Show resolved Hide resolved
mateoflorido and others added 3 commits December 14, 2022 10:54
Co-authored-by: Adam Dyess <adam.dyess@canonical.com>
Copy link
Member

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍰

@addyess addyess merged commit 9b27a51 into main Dec 15, 2022
@mateoflorido mateoflorido deleted the bug/lp1999532 branch December 16, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants