Darwin: bump Mac OS X version minimum to 10.14 #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwhite91
requested review from
rbuch,
matthiasdiener,
ericjbohm and
evan-charmworks
|
What benefits does this provide? We should document it in the commit message |
|
I believe this version requirement refers to the minimum supported Xcode / toolchain to build with this mode. However, the built binaries should be runnable on earlier versions. That said, 10.7 is still quite old, so generating binaries compatible that far back may have impacts on the resulting performance. I don't know the answer and it needs research. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for enabling C++17 usage on Mac OS X.