Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse data from query/api request screen while editing the chart to increase the efficiency #16

Closed
razvanilin opened this issue Dec 14, 2019 · 1 comment
Labels
enhancement New feature

Comments

@razvanilin
Copy link
Member

What's the issue

When a request is made using the API or Query builder the data is not used further and it causes the preview function to request the same data from the backend (and consequently from the connection) again.

How can this work better

It should follow these steps:

  1. Make/build query or API request
  2. Request the data from the connection
  3. The user goes to the Build Chart step and configures the dataset
  4. When the _onPreview function in the AddChart container fires, it reuses the data from step 2
  5. The Back-end will need to be modified to accept this data without making a new request to the connection
  6. When the user clicks on the Create or Update button to end the editing, the data should be reused again so that the loading doesn't take forever when dealing with big datasets
@razvanilin razvanilin added the enhancement New feature label Dec 14, 2019
@razvanilin razvanilin added this to To do in Chartbrew Devlog Dec 14, 2019
@razvanilin razvanilin changed the title 🔼 Cache data while editing the chart to increase the efficiency Reuse data from query/api request screen while editing the chart to increase the efficiency Dec 14, 2019
@razvanilin
Copy link
Member Author

Closing this as the current cache feature works in a similar way.

@razvanilin razvanilin moved this from To do to Done in Chartbrew Devlog Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
Development

No branches or pull requests

1 participant