Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out what to do with serde_yaml #1723

Closed
auguwu opened this issue Mar 27, 2024 · 1 comment
Closed

Figure out what to do with serde_yaml #1723

auguwu opened this issue Mar 27, 2024 · 1 comment
Assignees
@spotlightishere @auguwu
Labels
deps question Further information is requested rust Pull requests that update Rust code wontfix This will not be worked on

Comments

@auguwu
Copy link
Member

auguwu commented Mar 27, 2024

As of March 24th, 2024 (was also my 20th birthday), serde_yaml was deprecated and charted-server heavily relies on serde_yaml for the Helm-related operations it needs to do.

While it's not at the upmost priority, should we replace it with a different crate and experiment with it?
@auguwu auguwu added question Further information is requested wontfix This will not be worked on rust Pull requests that update Rust code deps labels Mar 27, 2024
@auguwu
Copy link
Member Author

auguwu commented Aug 21, 2024

We decided to go with serde_yaml_ng as it is the same API and doesn't try to be something new.

@auguwu auguwu closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spotlightishere spotlightishere

@auguwu auguwu

Labels
deps question Further information is requested rust Pull requests that update Rust code wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spotlightishere @auguwu