-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documenting wrappers and other interfaces #36
Comments
Cool man 😄 I've started my own one but never invested a lot of time. It was more a PoC. Nice to see that you've implemented something! I'll give it a go this weekend and maybe report some issues. I'm fine if the ng-chartist module is living in your house. I'll definitely contribute to the module when there is work and I find time. One thought I had, what would actually be nice, is if the series data can be done with nested directives. This way the core configuration could be done declaratively in HTML. Once I've tested your module and it's ready to be used, I'll list it in the documentation and the readme of Chartist of course. Awesome move to start this module! |
@Paradox41 if we update the ng-chartist.js to 0.2.0 I'll add it to the next release of the documentation. I will include a new section on the chartist landing page that shows wrapper libraries and projects where it has been used so far. |
That sounds easy enough 😄 |
@gionkunz I've done some work on this already, but I wanted to know if you had any plans for other events or a way to programmatically access available events. At the moment, my code will accept whatever event and handler get passed and obviously only ones that are emitted will get called. Which might lead to some confusing behavior (maybe?). Then again, my directive is intended to be a dumb wrapper, I don't really want to have too much knowledge about what the underlying library is doing. Thoughts? |
Finally got to this 🎉 Although the library evolved a lot now and we need to update the angular directive :-) There is now also a asterisks subscription for the event emitter that allows you to subscribe for all events and also there are animations with SMIL. |
Cool. When I get a chance I'll read through the docs and see what needs to change. |
In the README, number 4 states you would like better interfaces, like an Angular wrapper. Did you have any thoughts in mind on where these would go / where they would be listed? (I actually just wrote one, so this is partly a shameless plug lol)
But I do think it would be a good idea to have a list of wrappers that are available so people can find them easily.
The text was updated successfully, but these errors were encountered: