Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests and refactor to make code more testable #8

Closed
gionkunz opened this issue Aug 30, 2014 · 7 comments
Closed

Add more tests and refactor to make code more testable #8

gionkunz opened this issue Aug 30, 2014 · 7 comments

Comments

@gionkunz
Copy link
Collaborator

No description provided.

@valotas
Copy link

valotas commented Sep 14, 2014

Shall I put the tests under source/scripts named with a spec.js suffix? I really do not like creating test in a different folder.

@gionkunz
Copy link
Collaborator Author

I also like to put test files into the folder where the component under test lives. However, for a library project with less components I don't see the same benefit as with an application where you might end up with 30+ components. Also it's still quite common to use a test folder and given possible future contributions with people who are more used to a test folder, I'd rather go with the current approach.

@gionkunz
Copy link
Collaborator Author

It would be awesome if the project also contains everything required so we can run the tests on Travis!

@valotas
Copy link

valotas commented Sep 14, 2014

I'll start with the tests first :)

@valotas
Copy link

valotas commented Sep 14, 2014

And I think I'll integrate first istanbul so that I'll know what to test

@gionkunz
Copy link
Collaborator Author

Cool, istanbul is awesome! :-)

@gionkunz
Copy link
Collaborator Author

gionkunz commented Feb 1, 2015

As we have now some code coverage I'll close this issue. There is still need for more tests but this is no longer a blocker for 1.0.0

@gionkunz gionkunz closed this as completed Feb 1, 2015
dangreen added a commit that referenced this issue Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants