Config is no longer updated by options setter (#8516)

chartjs · Feb 24, 2021 · 2edd07d · 2edd07d
1 parent b31352c
commit 2edd07d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/core/core.config.js b/src/core/core.config.js
@@ -80,25 +80,21 @@ function mergeScaleConfig(config, options) {
   return scales;
 }
 
-function initOptions(config, options) {
-  options = options || {};
+function initOptions(config) {
+  const options = config.options || (config.options = {});
 
   options.plugins = valueOrDefault(options.plugins, {});
   options.scales = mergeScaleConfig(config, options);
-
-  return options;
 }
 
 function initConfig(config) {
   config = config || {};
 
-  // Do NOT use mergeConfig for the data object because this method merges arrays
-  // and so would change references to labels and datasets, preventing data updates.
   const data = config.data = config.data || {datasets: [], labels: []};
   data.datasets = data.datasets || [];
   data.labels = data.labels || [];
 
-  config.options = initOptions(config, config.options);
+  initOptions(config);
 
   return config;
 }
@@ -150,14 +146,18 @@ export default class Config {
     return this._config.options;
   }
 
+  set options(options) {
+    this._config.options = options;
+  }
+
   get plugins() {
     return this._config.plugins;
   }
 
-  update(options) {
+  update() {
     const config = this._config;
     this.clearCache();
-    config.options = initOptions(config, options);
+    initOptions(config);
   }
 
   clearCache() {

diff --git a/src/core/core.controller.js b/src/core/core.controller.js
@@ -159,7 +159,7 @@ class Chart {
   }
 
   set options(options) {
-    this.config.update(options);
+    this.config.options = options;
   }
 
   /**
@@ -444,7 +444,7 @@ class Chart {
     const me = this;
     const config = me.config;
 
-    config.update(config.options);
+    config.update();
     me._options = config.createResolver(config.chartOptionScopes(), me.getContext());
 
     each(me.scales, (scale) => {