Skip to content

Commit

Permalink
Allow passing a value to the time scale getPixelForValue method
Browse files Browse the repository at this point in the history
  • Loading branch information
etimberg committed Jun 21, 2016
1 parent ebaade5 commit 48ac791
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/scales/scale.time.js
Expand Up @@ -327,6 +327,7 @@ module.exports = function(Chart) {
},
getPixelForValue: function(value, index, datasetIndex) {
var me = this;
value = moment(value);
var labelMoment = value && value.isValid && value.isValid() ? value : me.getLabelMoment(datasetIndex, index);

if (labelMoment) {
Expand Down
1 change: 1 addition & 0 deletions test/scale.time.tests.js
Expand Up @@ -391,6 +391,7 @@ describe('Time scale tests', function() {

expect(xScale.getPixelForValue('', 0, 0)).toBeCloseToPixel(78);
expect(xScale.getPixelForValue('', 6, 0)).toBeCloseToPixel(452);
expect(xScale.getPixelForValue('2015-01-01T20:00:00')).toBeCloseToPixel(78);

expect(xScale.getValueForPixel(78)).toBeCloseToTime({
value: moment(chartInstance.data.labels[0]),
Expand Down

0 comments on commit 48ac791

Please sign in to comment.