Skip to content

Commit

Permalink
Review update
Browse files Browse the repository at this point in the history
  • Loading branch information
kurkle committed Jan 8, 2020
1 parent 74e90d4 commit 9e6c90b
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions test/specs/scale.logarithmic.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -1009,9 +1009,9 @@ describe('Logarithmic Scale tests', function() {
var start = chart.chartArea[axis.start];
var end = chart.chartArea[axis.end];

expect(scale.getPixelForValue(firstTick, 0, 0)).toBeCloseToPixel(start);
expect(scale.getPixelForValue(lastTick, 0, 0)).toBeCloseToPixel(end);
expect(scale.getPixelForValue(0, 0, 0)).toBeCloseToPixel(start); // 0 is invalid, put it at the start.
expect(scale.getPixelForValue(firstTick)).toBeCloseToPixel(start);
expect(scale.getPixelForValue(lastTick)).toBeCloseToPixel(end);
expect(scale.getPixelForValue(0)).toBeCloseToPixel(start); // 0 is invalid, put it at the start.

expect(scale.getValueForPixel(start)).toBeCloseTo(firstTick, 4);
expect(scale.getValueForPixel(end)).toBeCloseTo(lastTick, 4);
Expand All @@ -1023,8 +1023,8 @@ describe('Logarithmic Scale tests', function() {
start = chart.chartArea[axis.end];
end = chart.chartArea[axis.start];

expect(scale.getPixelForValue(firstTick, 0, 0)).toBeCloseToPixel(start);
expect(scale.getPixelForValue(lastTick, 0, 0)).toBeCloseToPixel(end);
expect(scale.getPixelForValue(firstTick)).toBeCloseToPixel(start);
expect(scale.getPixelForValue(lastTick)).toBeCloseToPixel(end);

expect(scale.getValueForPixel(start)).toBeCloseTo(firstTick, 4);
expect(scale.getValueForPixel(end)).toBeCloseTo(lastTick, 4);
Expand Down Expand Up @@ -1057,12 +1057,12 @@ describe('Logarithmic Scale tests', function() {
{
dataset: [{x: 0, y: 0}, {x: 10, y: 10}, {x: 1.2, y: 1.2}, {x: 25, y: 25}, {x: 78, y: 78}],
lastTick: 80,
describe: 'dataset min point {x: 0, y: 0}, max point {x:78, y:78}, minNotZero {x: 1.2, y: 1.2}'
describe: 'dataset min point {x: 0, y: 0}, max point {x:78, y:78}'
},
{
dataset: [{x: 0, y: 0}, {x: 10, y: 10}, {x: 6.3, y: 6.3}, {x: 25, y: 25}, {x: 78, y: 78}],
lastTick: 80,
describe: 'dataset min point {x: 0, y: 0}, max point {x:78, y:78}, minNotZero {x: 6.3, y: 6.3}'
describe: 'dataset min point {x: 0, y: 0}, max point {x:78, y:78}'
},
{
dataset: [{x: 10, y: 10}, {x: 1.2, y: 1.2}, {x: 25, y: 25}, {x: 78, y: 78}],
Expand Down

0 comments on commit 9e6c90b

Please sign in to comment.